Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js/grpc: Deprecated headers param #2370

Merged
merged 1 commit into from
Feb 4, 2022
Merged

js/grpc: Deprecated headers param #2370

merged 1 commit into from
Feb 4, 2022

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Feb 3, 2022

Closes #2244. I saw it during the module migration.

It includes:

  • The refactoring of the parameters parsing part with a dedicated method.
  • A warning for communicating about the headers deprecation
  • The metadata support

@codebien codebien added this to the v0.37.0 milestone Feb 3, 2022
@codebien codebien self-assigned this Feb 3, 2022
@codebien codebien requested review from olegbespalov and removed request for yorugac February 3, 2022 17:37
mstoykov
mstoykov previously approved these changes Feb 4, 2022
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some error message comments

js/modules/k6/grpc/client.go Outdated Show resolved Hide resolved
Deprecated the headers parameter and replaced with the right name
metadata.
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

// Invoke creates and calls a unary RPC by fully qualified method name
//nolint: funlen,gocognit,gocyclo,cyclop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename grpc.Params.headers to metadata?
3 participants