js/modules: Remove common utils dependency #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
previously approved these changes
Feb 4, 2022
|
Can you also cleanup the tests as they still use |
na--
previously approved these changes
Feb 4, 2022
codebien
force-pushed
the
ws-remove-withruntime
branch
from
07fb1d5
to
0e1a7ac
Compare
codebien
changed the title
|
I extended the changes to all the tests in |
Something was missed from the module migration to the new `modules.Module` API, where the goja.Runtime and lib.State are now directly accessible without getting them from the context.
codebien
force-pushed
the
ws-remove-withruntime
branch
from
0e1a7ac
to
22346f6
Compare
na--
reviewed
Feb 7, 2022
| time.Sleep(1 * time.Second) | ||
| runtime.Gosched() |
There was a problem hiding this comment.
I wonder why these were here? 😕 Seems they were here from almost the start (274eef8), but they don't seem necessary, so 👍 for removing them
mstoykov
approved these changes
Feb 7, 2022
olegbespalov
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something was missed from the module migration to the new
modules.ModuleAPI, where the Runtime and the State are now directly accessible without getting them from the context.This is required for #2344