Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1443 remove js runtime from threshold calculation #2400

Merged
merged 2 commits into from
Mar 3, 2022
Merged

Fix/1443 remove js runtime from threshold calculation #2400

merged 2 commits into from
Mar 3, 2022

Commits on Feb 25, 2022

  1. Revert "Revert "Merge pull request #2251 from grafana/fix/1443_remove… 

    …_the_js_runtime_from_threshold_calcultations""

This reverts commit 22a0db3.
    @oleiade
    oleiade committed Feb 25, 2022
    Configuration menu
    Copy the full SHA
    7a9d184 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Ensure thresholds parsing is skipped on --no-thresholds 

    This commit ensures that thresholds parsing is a separate step, done
only when the `--no-threshold` flag is not set.

Note that this commit deactivates tests that assumed
`Thresholds.UnmarshalJSON` to effectively parse the thresholds.
    @oleiade
    oleiade committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    69a2169 View commit details
    Browse the repository at this point in the history