Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other dependencies p.1 #2449

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Other dependencies p.1 #2449

merged 7 commits into from
Mar 18, 2022

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Mar 17, 2022 •
edited
Loading

From what I checked the changes have nothing really interesting for us, but on the other side there are bugfixes, and at some point, we probably might want to use the future versions, so it's good to keep diff smaller.

  • Maintenance update of gorilla/websocket to v1.5.0 from v1.4.2
  • Maintenance update of stretchr/testify to v1.7.1 from v1.7.0
  • Maintenance update of github.com/jhump/protoreflect to v1.12.0 from `v1.10.0
  • Maintenance update of PuerkitoBio/goquery to v1.8.0 from v1.6.1
  • Maintenance update of andybalholm/brotli to v1.0.4 from v1.0.3
  • Maintenance update of google.golang.org/grpc to v1.45.0 from v1.41.0
  • Maintenance update of tidwall/gjson to v1.14.0 from v1.10.2

Main issue: #2445

@github-actions github-actions bot requested review from na-- and oleiade March 17, 2022 09:53
@olegbespalov olegbespalov added maintenance dependencies Pull requests that update a dependency file labels Mar 17, 2022
@olegbespalov olegbespalov added this to the v0.38.0 milestone Mar 17, 2022
@olegbespalov olegbespalov self-assigned this Mar 17, 2022
mstoykov
mstoykov previously approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stretchr/testify got updarte from v1.7.0 to v1.7.1 ;)

Also I prefer if the proto stuff get updated together, but otherwise LGTM!

@olegbespalov olegbespalov mentioned this pull request Mar 17, 2022
Closed
5 tasks
oleiade
oleiade previously approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@oleiade oleiade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me 😎 🦕 🎉

@olegbespalov olegbespalov merged commit 772d00a into master Mar 18, 2022
@olegbespalov olegbespalov deleted the feat/other-dependencies branch March 18, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleiade oleiade oleiade approved these changes

@mstoykov mstoykov mstoykov approved these changes

@na-- na-- Awaiting requested review from na--

Assignees

@olegbespalov olegbespalov

Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@olegbespalov @mstoykov @oleiade