Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic due to error in HasWork #2456

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Commits on Mar 24, 2022

  1. Fix panic due to error in HasWork

    The panic was happening in the `Init` but it was due to the fact that
    HasWork wrongfully returned True when it should've returned false.
    mstoykov committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    029f6f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Use only ExecutionTuple.ScaleInt64 in executors

    Most executors use that already and while ExecutionSegment.Scale gives
    the same result in a lot of cases - it doesn't in some. This potentially
    can lead to small (1 VU/iteration) discrepancies but more importantly
    panics. Especially in cases where the differences are when one returns a
    0 and the other a 1 for a given value.
    mstoykov committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    61c90fe View commit details
    Browse the repository at this point in the history