Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #2900

Closed
wants to merge 2 commits into from
Closed

WIP #2900

wants to merge 2 commits into from

Commits on Feb 2, 2023

  1. js: refactor how modules are loaded

    This refactor tries to simplify the implementation of `require` and
    connected code by splitting it heavily into different parts.
    
    These changes are similar to what will be needed for native ESM support
    as shown in #2563 , but without any of
    the native parts and without doing anything that isn't currently needed.
    This will hopefully make ESM PR much smaller and less intrusive.
    
    This includes still keeping the wrong relativity of `require` as
    explained in #2674.
    
    It also tries to simplify connected code, but due to this being very
    sensitive code and the changes already being quite big, this is done
    only to an extent.
    
    The lack of new tests is mostly due to there not being really any new
    code and the tests that were created along these changes already being
    merged months ago with #2782.
    
    Future changes will try to address the above as well as potentially
    moving the whole module types and logic in separate package to be reused
    in tests.
    mstoykov committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    8d38091 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. WIP

    mstoykov committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e4367e2 View commit details
    Browse the repository at this point in the history