Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRPC experimental module #3107

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 1, 2023

What?

This PR brings the experimental GRPC module to a k6.

How to try?

Build a k6

go build .

Run an example service.

go run -mod=mod examples/grpc_server/*.go

and

./k6 run examples/experimental/grpc/server_streaming.js

or

./k6 run examples/experimental/grpc/client_streaming.js

Why?

Related: #2020

@olegbespalov olegbespalov added enhancement documentation-needed A PR which will need a separate PR for documentation dependencies Pull requests that update a dependency file area: grpc labels Jun 1, 2023
@olegbespalov olegbespalov self-assigned this Jun 1, 2023
@olegbespalov olegbespalov added this to the v0.45.0 milestone Jun 1, 2023
codebien
codebien previously approved these changes Jun 1, 2023
Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

mstoykov
mstoykov previously approved these changes Jun 1, 2023
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just if we can fix the one dependancy

go.sum Outdated Show resolved Hide resolved
@olegbespalov olegbespalov dismissed stale reviews from mstoykov and codebien via 9d58823 June 1, 2023 11:16
@olegbespalov olegbespalov force-pushed the feat/grpc-experimental-module branch from 0167ce4 to 9d58823 Compare June 1, 2023 11:16
@codecov-commenter
Copy link

Codecov Report

Merging #3107 (9e272c1) into master (23ff170) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9e272c1 differs from pull request most recent head 9d58823. Consider uploading reports for the commit 9d58823 to get more accurate results

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
+ Coverage   73.72%   73.74%   +0.02%     
==========================================
  Files         241      241              
  Lines       18461    18457       -4     
==========================================
+ Hits        13610    13612       +2     
+ Misses       3978     3972       -6     
  Partials      873      873              
Flag Coverage Δ
ubuntu 73.74% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/jsmodules.go 100.00% <100.00%> (ø)
output/cloud/expv2/output.go 84.14% <100.00%> (+3.68%) ⬆️

... and 1 file with indirect coverage changes

@olegbespalov olegbespalov merged commit 7db9a8e into master Jun 1, 2023
@olegbespalov olegbespalov deleted the feat/grpc-experimental-module branch June 1, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: grpc dependencies Pull requests that update a dependency file documentation-needed A PR which will need a separate PR for documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants