Use docker buildx to publish images #3127
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewslotin
force-pushed
the
use_buildx_to_publish_images
branch
from
7600cc0
to
dd11c0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3127 +/- ##
==========================================
- Coverage 73.86% 73.85% -0.02%
==========================================
Files 243 243
Lines 18492 18492
==========================================
- Hits 13659 13657 -2
- Misses 3964 3966 +2
Partials 869 869
Flags with carried forward coverage won't be shown. Click here to find out more. |
imiric
pushed a commit
that referenced
this pull request
Jun 16, 2023
This reverts commit 9fa50b2. Pushing of ARM images is not working[1], and there are issues with pushing master images[2]. Rather than deal with risky fixes with buildx days before the v0.45.0 release, we've decided to roll back this change and migrate to buildx later, once we've understood and tested the build process better. [1]: #3015 (comment) [2]: #3127
imiric
pushed a commit
that referenced
this pull request
Jun 16, 2023
This reverts commit 9fa50b2. Pushing of ARM images is not working[1], and there are issues with pushing master images[2]. Rather than deal with risky fixes with buildx days before the v0.45.0 release, we've decided to roll back this change and migrate to buildx later, once we've understood and tested the build process better. [1]: #3015 (comment) [2]: #3127
|
Closing as not necessary, since #3015 has been reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with the current build process not pushing the latest built image caused by #3015. For example
grafana/k6:masterimage built a few days ago is the same asgrafana/k6:0.44.1that has been pushed a month ago.The reason for this is that
docker buildxuses a different context to build images, which means that all subsequent docker run and docker push commands work with an image that is different from what has been built at the “Build” step.The reason why this went unnoticed is the “Check” step, that “fixes” default context state by pulling the latest grafana/k6 image from DockerHub and this is the image used by all subsequent stages.
Once this applied,
build-dockerjob will start usingdocker buildx --pushto publish the image frommultibuildercontext instead ofdefault. Since we don't change any files in-between, this command always uses the cached image created during the "Build" step. To run smoke test at the "Check" stage, we're going to load it into thedefaultcontext by executingdocker buildx --loadbefore running the image.