Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PR template #3131

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Update PR template #3131

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d66ed3
Update PR template
olegbespalov Jun 19, 2023
dafbf69
Apply suggestions from code review
olegbespalov Jun 19, 2023
071f7c4
Apply suggestions from code review
olegbespalov Jun 19, 2023
0bacfff
Apply suggestions from code review
olegbespalov Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 30 additions & 19 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,31 @@
<!--


(ﾉ◕ヮ◕)ﾉ*:・ﾟ✧

Thank you for your interest in contributing to the k6 project!

Before you get started, we'd kindly like to ask you to read our:
- Contribution guidelines at https://github.com/grafana/k6/blob/master/CONTRIBUTING.md
- Code of Conduct at https://github.com/grafana/k6/blob/master/CODE_OF_CONDUCT.md

Out of respect for your time, please start a discussion regarding any bigger contributions either
in a GitHub Issue, in the community forums or in the #contributors channel of the k6 slack before you
get started on the implementation.

If you've already done all of that, you're more than welcome to proceed with your pull request.
Thank you again for your contribution! 🙏🏼
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved


## What?

<!-- A short (or detailed) description of what this PR does. -->

## Why?

<!-- A short (or detailed) explanation of why these changes are made and needed. -->

## Checklist

<!--
If you haven't reed the contributing guidelines https://github.com/grafana/k6/blob/master/CONTRIBUTING.md
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved
and code of conduct https://github.com/grafana/k6/blob/master/CODE_OF_CONDUCT.md yet, please do so
-->

- [ ] I have performed a self-review of my code.
- [ ] I have added tests for my changes.
- [ ] I have run linter locally (`make ci-like-lint`) and all checks pass.
- [ ] I have run tests locally (`make test`) and all tests pass.
- [ ] I have commented on my code, particularly in hard-to-understand areas.
<!-- - [ ] ANYTHING ELSE -->
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved

## Related PR(s)/Issue(s)

<!-- - <https://github.com/grafana/...> -->

<!-- Does it close an issue? -->

<!-- Closes #ISSUE-ID -->

<!-- Thank for your contribution! 🙏🏼 -->
olegbespalov marked this conversation as resolved.
Show resolved Hide resolved