Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix examples/grpc.js #3163

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix examples/grpc.js #3163

merged 1 commit into from
Jul 5, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jul 5, 2023

No description provided.

@mstoykov
Copy link
Contributor Author

mstoykov commented Jul 5, 2023

This was broken in 703fd57

olegbespalov
olegbespalov approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to port it from xk6-grpc 🤦

@olegbespalov olegbespalov added this to the v0.46.0 milestone Jul 5, 2023
@mstoykov mstoykov merged commit ac9bfd5 into master Jul 5, 2023
@mstoykov mstoykov deleted the fixGRPCExample branch July 5, 2023 08:46
@olegbespalov olegbespalov mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
area: grpc docs
Projects
None yet
Milestone
v0.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mstoykov @codebien @olegbespalov