Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating experimental GRPC module #3211

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jul 19, 2023

What?

This brings changes (see related PRs) from the xk6-grpc:

  • Ommiting EOF for the send
  • Backporting of Fix for the registering nested types
  • Backporting of Support for per-vu TLS configuration
  • Non-significant changes

Why?

With the k6 v0.46 we also want to ship updates to the experimental GRPC module.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov added lower prio dependencies Pull requests that update a dependency file area: grpc labels Jul 19, 2023
@olegbespalov olegbespalov self-assigned this Jul 19, 2023
@olegbespalov olegbespalov added this to the v0.46.0 milestone Jul 19, 2023
@olegbespalov olegbespalov force-pushed the feat/updating-grpc-experimental branch from 41d700d to b04c28c Compare July 19, 2023 12:40
@olegbespalov olegbespalov changed the title feat: updating experimental GRPC module Updating experimental GRPC module Jul 19, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3211 (3d7e678) into master (dccdf16) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head 3d7e678 differs from pull request most recent head b04c28c. Consider uploading reports for the commit b04c28c to get more accurate results

@@            Coverage Diff             @@
##           master    #3211      +/-   ##
==========================================
- Coverage   72.89%   72.82%   -0.07%     
==========================================
  Files         259      257       -2     
  Lines       19810    19805       -5     
==========================================
- Hits        14440    14423      -17     
- Misses       4470     4477       +7     
- Partials      900      905       +5     
Flag Coverage Δ
ubuntu 72.82% <ø> (-0.02%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@mstoykov mstoykov merged commit 59d9f9b into master Jul 24, 2023
20 checks passed
@mstoykov mstoykov deleted the feat/updating-grpc-experimental branch July 24, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: grpc dependencies Pull requests that update a dependency file lower prio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants