Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new auth headers required for tailing k6 Cloud logs #3224

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

federicotdn
Copy link
Contributor

@federicotdn federicotdn commented Jul 24, 2023

What?

Adds two new HTTP headers required to tail logs from k6 Cloud in the near future.

Why?

See issue #3216 and backlinked issue from the Grafana private repository.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3216

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #3224 (dbd85f2) into master (59d9f9b) will decrease coverage by 0.02%.
The diff coverage is 96.22%.

❗ Current head dbd85f2 differs from pull request most recent head e80b072. Consider uploading reports for the commit e80b072 to get more accurate results

@@            Coverage Diff             @@
##           master    #3224      +/-   ##
==========================================
- Coverage   73.18%   73.17%   -0.02%     
==========================================
  Files         259      257       -2     
  Lines       19864    19886      +22     
==========================================
+ Hits        14538    14551      +13     
- Misses       4404     4408       +4     
- Partials      922      927       +5     
Flag Coverage Δ
ubuntu 73.17% <96.22%> (+0.04%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/expv2/flush.go 93.40% <94.59%> (+2.36%) ⬆️
cloudapi/logs.go 85.29% <100.00%> (+0.29%) ⬆️
output/cloud/expv2/output.go 74.23% <100.00%> (+1.39%) ⬆️

... and 8 files with indirect coverage changes

@mstoykov mstoykov requested a review from oleiade July 25, 2023 13:57
@mstoykov mstoykov merged commit 6c31075 into master Jul 26, 2023
@mstoykov mstoykov deleted the feat/3216-update-loki-tail-auth branch July 26, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants