Log errors when executing setup and teardown via REST API #3290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds error logging when executing the setup and teardown functions in the k6 API. If an error occurs during setup or teardown, it will now be logged with the corresponding error message. This improves error reporting and makes it easier to diagnose issues related to setup and teardown. Related issue: grafana#2422
kmtym1998
changed the title
olegbespalov
approved these changes
Aug 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #3290 +/- ##
==========================================
- Coverage 73.21% 73.09% -0.13%
==========================================
Files 258 256 -2
Lines 19884 19881 -3
==========================================
- Hits 14559 14532 -27
- Misses 4402 4419 +17
- Partials 923 930 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
olegbespalov
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
@kmtym1998 change looks good to me 👍 Thanks for the contribution!
oleiade
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds error logging for setup and teardown functions invoked from REST API.
Why?
Error logging is added to enhance visibility into errors during setup and teardown, aiding debugging.
Checklist
make ci-like-lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #2422