Update goja #3339
Merged
Update goja #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates makes the runtime initialization faster and *lighter*. For empty and fairly small scripts the observed initialization improvement by some fast "benchmarking" for k6 this means: 1. around 3x faster initialization of VUs 2. around 4x less memory usage. This likely will be nearly unnoticeable as this is only reasonably easy to see with 100k VUs for the initialization speed where it goes from around 10s to a little over 3s. Adding more code increases both linearly, so bigger scripts will have some speed up but it won't be 3x. Same seems to be for memory usages as well. Both of those likely get way worse if more and more of the JavaScript "standard library" is used as in that case all of those now templated properties will be used.
mstoykov
force-pushed
the
updateGoja
branch
from
ac4e5c8
to
d672bb3
Compare
olegbespalov
approved these changes
Sep 19, 2023
codebien
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates makes the runtime initialization faster and lighter.
For empty and fairly small scripts the observed initialization improvement by some fast "benchmarking" for k6 this means:
This likely will be nearly unnoticeable as this is only reasonably easy to see with 100k VUs for the initialization speed where it goes from around 10s to a little over 3s.
Adding more code increases both linearly, so bigger scripts will have some speed up, but it won't be 3x.
Same seems to be for memory usages as well.
Both of those likely get way worse if more and more of the JavaScript "standard library" is used as in that case all of those now templated properties will be used.
Changelog
internal: update goja with some runtime initialization speed-ups
The speed-ups are around 3x and there is 4x memory reduction for empty scripts. Anything more complex adds and using JS types or importing libraries decrease this as it just adds to the actual initialization in ways this optimization does not help.