-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/relnot: Release notes generator #3359
Conversation
0ac611a
to
01ea5c9
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3359 +/- ##
==========================================
- Coverage 72.96% 72.36% -0.61%
==========================================
Files 261 262 +1
Lines 20018 20166 +148
==========================================
- Hits 14607 14593 -14
- Misses 4484 4635 +151
- Partials 927 938 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
I just gave this a shot on my Mac locally, and I got an error, which if I understand this properly, means no
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thanks for doing this! 🙇
My main question is, why should the tool's code be in the k6 repository?
Even if it aims solely to serve grafana/k6 repo, it still sounds more like a mini-repository that could be well-organized and follow its structure: README, CODEOWNERS, DEPENDENCIES, and so on.
@codebien I see that you closed the PR. Could you please also comment for the reference why you did that or maybe what are the next steps here. Thanks! |
Hey @olegbespalov, I just closed it as it isn't in our current priorities. I may restore it the next time I will be the release driver. If in the meantime, someone else needs/wants to use or expand it, feel free to go ahead and/or provide feedback. |
What?
It picks a list of merged pull requests for a specific milestone adding them to an
unreleased.md
file. The final vision is to run this script once a week (e.g. on Monday) - before manually for the first cycle then automatically from a GitHub Action generating a pull request for amending theunreleased.md
file.Why?
It reduces the effort of manually generating and syncing the release notes, forcing each contributor to write individually the changelog of each PR. It is built on our current template as we want to keep writing release notes for humans.