Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to gh from hub in workflows #3371

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Switch to gh from hub in workflows #3371

merged 1 commit into from
Oct 9, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Oct 6, 2023

What?

Github removed hub command from the images and now we should use gh

actions/runner-images#8362

Why?

So we can make release without installing hub back.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added the ci label Oct 6, 2023
@mstoykov mstoykov added this to the v0.47.0 milestone Oct 6, 2023
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇 🤞

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6aa49bc) 72.94% compared to head (6e5afa5) 72.88%.

❗ Current head 6e5afa5 differs from pull request most recent head c0e125c. Consider uploading reports for the commit c0e125c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3371      +/-   ##
==========================================
- Coverage   72.94%   72.88%   -0.07%     
==========================================
  Files         261      259       -2     
  Lines       20018    20013       -5     
==========================================
- Hits        14602    14586      -16     
- Misses       4489     4495       +6     
- Partials      927      932       +5     
Flag Coverage Δ
ubuntu 72.88% <ø> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstoykov should we test the command on a fake project?

@mstoykov
Copy link
Contributor Author

mstoykov commented Oct 9, 2023

@codebien we did on some internal ones.

@mstoykov mstoykov merged commit c742a54 into master Oct 9, 2023
21 checks passed
@mstoykov mstoykov deleted the switchToGH branch October 9, 2023 12:10
@mstoykov mstoykov mentioned this pull request Oct 10, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants