Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to the release task templates #3385

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Oct 12, 2023

What?

Minor fixes to the release task template:

  • Avoid tagging teams at the beginning. Fix devrel since this is a real Github handle and it's mentioning
  • Minor style & grammar fixes

Why?

Improve the release task template

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov self-assigned this Oct 12, 2023
@olegbespalov olegbespalov added this to the v0.48.0 milestone Oct 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (00ee7ae) 72.96% compared to head (7eac523) 72.96%.

❗ Current head 7eac523 differs from pull request most recent head dda99a7. Consider uploading reports for the commit dda99a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   72.96%   72.96%   -0.01%     
==========================================
  Files         261      261              
  Lines       20018    20018              
==========================================
- Hits        14607    14606       -1     
- Misses       4484     4485       +1     
  Partials      927      927              
Flag Coverage Δ
ubuntu 72.83% <ø> (-0.07%) ⬇️
windows 72.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov merged commit 4b4317b into master Oct 12, 2023
22 checks passed
@olegbespalov olegbespalov deleted the chore/adjust-release-task branch October 12, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants