Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --logformat flag #3389

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Remove the --logformat flag #3389

merged 1 commit into from
Nov 20, 2023

Conversation

codebien
Copy link
Contributor

What?

Removed the deprecated --logformat flag, the --log-format alternative should be used.

Why?

Deprecation process.

Removed the deprecated --logformat flag, the --log-format alternative
should be used.
@codebien codebien self-assigned this Oct 12, 2023
@codebien codebien added this to the v0.48.0 milestone Oct 12, 2023
@codebien codebien marked this pull request as ready for review October 12, 2023 11:24
@olegbespalov olegbespalov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Oct 12, 2023
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mstoykov
Copy link
Contributor

Given that this is still so widely used it might be worth postponing this a release or three after we remove it everywhere.

This isn't really a problem we need to fix, but breaking user experiecne is not great if until yesterday we were telling them to a thing .

@codebien
Copy link
Contributor Author

This isn't really a problem we need to fix, but breaking user experiecne is not great if until yesterday we were telling them to a thing .

If you use --logformat then you get a clear message about the deprecation, and apparently, we added it 10 versions ago.

$ k6 run --logformat raw ./examples/http_get.js
Flag --logformat has been deprecated, log-format

I value it more visible than the writing we did in the release notes. So, I'm for fixing the other occurrences and removing it in the current version, if someone didn't fix it till now then I wouldn't expect that giving them more versions will make a difference.

@olegbespalov
Copy link
Contributor

In my opinion, I don't think that we need to postpone this shrug: We need to fix usage, and we have plenty of time.

However, I might think that following v0.48 could be one of the biggest from the perspective of breaking changes 😅

@codebien
Copy link
Contributor Author

@olegbespalov the other parts have been changed, we should be now ready to merge this.

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@codebien
Copy link
Contributor Author

@oleiade as @mstoykov is on PTO, I add you as a reviewer.

@codebien codebien merged commit a087d42 into master Nov 20, 2023
23 checks passed
@codebien codebien deleted the drop-logformat branch November 20, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants