Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Makefile's ci-like-lint target #3401

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

olegbespalov
Copy link
Contributor

What?

We introduced the ci-like-lint target a while ago #2316. Since then, our linter's config didn't have the list of used linters, and upgrading the golangci-lint could cause triggering issues that were never seen before, which slowed the process of the actual work.

In #2715 we switched to the close-list of the linters that we run, and using different versions of the golangci-lint shouldn't cause a significant difference.

It seems safe to remove the ci-like-lint and keep only the lint target which runs on the host machine.

Also, this PR updates the version of the golangci and refactors a bit the Makefile, making it self-explanatory.

Why?

Removing the ci-like-lint we do a cleanup and simplify the process. It also improves the developer UX since the make lint is more common and intuitive for the developers. Last, but not least running the linters on the host machine is simply faster than inside the docker.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e8886ac) 73.13% compared to head (ff94128) 73.15%.
Report is 6 commits behind head on master.

❗ Current head ff94128 differs from pull request most recent head 75fb153. Consider uploading reports for the commit 75fb153 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3401      +/-   ##
==========================================
+ Coverage   73.13%   73.15%   +0.01%     
==========================================
  Files         258      258              
  Lines       19642    19641       -1     
==========================================
+ Hits        14365    14368       +3     
+ Misses       4395     4391       -4     
  Partials      882      882              
Flag Coverage Δ
ubuntu 73.09% <40.00%> (+0.01%) ⬆️
windows 72.98% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cloudapi/config.go 90.90% <100.00%> (ø)
output/csv/config.go 74.50% <ø> (ø)
js/runner.go 86.42% <50.00%> (+0.67%) ⬆️
js/modules/k6/grpc/client.go 82.74% <0.00%> (-0.64%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov added this to the v0.48.0 milestone Oct 17, 2023
@olegbespalov olegbespalov merged commit 44e1e63 into master Oct 17, 2023
22 checks passed
@olegbespalov olegbespalov deleted the chore/golang-ci-linter branch October 17, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants