Remove Makefile's ci-like-lint
target
#3401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We introduced the
ci-like-lint
target a while ago #2316. Since then, our linter's config didn't have the list of used linters, and upgrading the golangci-lint could cause triggering issues that were never seen before, which slowed the process of the actual work.In #2715 we switched to the close-list of the linters that we run, and using different versions of the golangci-lint shouldn't cause a significant difference.
It seems safe to remove the
ci-like-lint
and keep only thelint
target which runs on the host machine.Also, this PR updates the version of the golangci and refactors a bit the Makefile, making it self-explanatory.
Why?
Removing the
ci-like-lint
we do a cleanup and simplify the process. It also improves the developer UX since themake lint
is more common and intuitive for the developers. Last, but not least running the linters on the host machine is simply faster than inside the docker.Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)