Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goja dependency version #3417

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Update goja dependency version #3417

merged 1 commit into from
Oct 25, 2023

Conversation

codebien
Copy link
Contributor

@codebien codebien commented Oct 24, 2023

What?

dop251/goja#543

Why?

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@codebien codebien self-assigned this Oct 24, 2023
@codebien codebien added this to the v0.48.0 milestone Oct 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (036f8a0) 73.34% compared to head (a4cbd6b) 73.33%.

❗ Current head a4cbd6b differs from pull request most recent head 5761401. Consider uploading reports for the commit 5761401 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3417      +/-   ##
==========================================
- Coverage   73.34%   73.33%   -0.02%     
==========================================
  Files         258      258              
  Lines       19645    19645              
==========================================
- Hits        14409    14407       -2     
- Misses       4351     4353       +2     
  Partials      885      885              
Flag Coverage Δ
ubuntu 73.27% <ø> (ø)
windows 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien marked this pull request as ready for review October 25, 2023 07:31
@codebien codebien removed the request for review from olegbespalov October 25, 2023 07:31
@codebien codebien merged commit 8e2c27a into master Oct 25, 2023
24 checks passed
@codebien codebien deleted the bump-goja branch October 25, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants