Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser.closeContext() to v0.48 release notes #3419

Merged

Conversation

ka3de
Copy link
Contributor

@ka3de ka3de commented Oct 25, 2023

What?

Adds an entry for the browser.closeContext() method under the UX improvements and enhancements section.

Why?

So it's properly documented as a new enhancement for the v0.48.0 release.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Code: grafana/xk6-browser#1074
Docs: grafana/k6-docs#1376

@ka3de ka3de self-assigned this Oct 25, 2023
@ka3de ka3de marked this pull request as ready for review October 25, 2023 07:50
@ka3de ka3de requested a review from inancgumus October 25, 2023 07:50
@ka3de ka3de requested review from ankur22, olegbespalov and codebien and removed request for oleiade and olegbespalov October 25, 2023 07:50
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-notes-v0.48.0@723eba9). Click here to learn what that means.

❗ Current head 31d0745 differs from pull request most recent head 05284d5. Consider uploading reports for the commit 05284d5 to get more accurate results

Additional details and impacted files
@@                   Coverage Diff                    @@
##             release-notes-v0.48.0    #3419   +/-   ##
========================================================
  Coverage                         ?   73.11%           
========================================================
  Files                            ?      258           
  Lines                            ?    19650           
  Branches                         ?        0           
========================================================
  Hits                             ?    14367           
  Misses                           ?     4401           
  Partials                         ?      882           
Flag Coverage Δ
ubuntu 73.04% <0.00%> (?)
windows 72.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ka3de ka3de merged commit 3194982 into release-notes-v0.48.0 Oct 30, 2023
22 of 23 checks passed
@ka3de ka3de deleted the update/release-v048-browser-closecontext branch October 30, 2023 13:34
@mstoykov mstoykov added this to the v0.48.0 milestone Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants