Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestSetupTimeout by increasing the time range it should finish in #3429

Merged
merged 1 commit into from
Nov 6, 2023
Merged

fix TestSetupTimeout by increasing the time range it should finish in #3429

merged 1 commit into from
Nov 6, 2023

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov mstoykov added this to the v0.48.0 milestone Oct 30, 2023
@mstoykov mstoykov added the ci label Oct 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92e3aca) 73.34% compared to head (a8a6ee0) 73.34%.

❗ Current head a8a6ee0 differs from pull request most recent head ccf5aef. Consider uploading reports for the commit ccf5aef to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3429   +/-   ##
=======================================
  Coverage   73.34%   73.34%           
=======================================
  Files         258      258           
  Lines       19645    19645           
=======================================
  Hits        14408    14408           
  Misses       4352     4352           
  Partials      885      885
Flag Coverage Δ
ubuntu 73.28% <ø> (ø)
windows 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien codebien requested review from oleiade and removed request for olegbespalov October 30, 2023 13:16
olegbespalov
olegbespalov approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH sounds really strange to have this big difference even if the github runner isn't so performant. But 👍

@mstoykov mstoykov merged commit 598ce91 into master Nov 6, 2023
22 checks passed
@mstoykov mstoykov deleted the setupTimeoutTestTimeoutIncrease branch November 6, 2023 14:27
@Porkepix Porkepix mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegbespalov olegbespalov olegbespalov approved these changes

@codebien codebien codebien approved these changes

@oleiade oleiade oleiade approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mstoykov @codecov-commenter @oleiade @codebien @olegbespalov