Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xk6-redis dependency to v0.2.0 #3439

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Nov 3, 2023

What?

This Pull Request updates the xk6-redis dependency backing the k6/experimental/redis module to version v0.2.0.

Why?

The latest version of xk6-redis addresses the support for (m)TLS, and updates the redis.Client constructor options to reflect that change. This is a module API breaking change, that should be documented accordingly 🤝

Related PR(s)/Issue(s)

ref grafana/xk6-redis#17
ref grafana/xk6-redis#14

go.mod Outdated Show resolved Hide resolved
@oleiade oleiade force-pushed the experimental/redis/update-version branch from cb7197c to 7637bdf Compare November 3, 2023 13:07
@oleiade oleiade changed the title Update xk6-redis dependency to v0.1.2 Update xk6-redis dependency to v0.2.0 Nov 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70c6284) 73.35% compared to head (ecbbd88) 73.35%.

❗ Current head ecbbd88 differs from pull request most recent head 7637bdf. Consider uploading reports for the commit 7637bdf to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3439   +/-   ##
=======================================
  Coverage   73.35%   73.35%           
=======================================
  Files         259      259           
  Lines       19659    19659           
=======================================
+ Hits        14420    14421    +1     
+ Misses       4354     4352    -2     
- Partials      885      886    +1     
Flag Coverage Δ
ubuntu 73.23% <ø> (-0.06%) ⬇️
windows 73.18% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oleiade oleiade merged commit 0ff7078 into master Nov 6, 2023
21 checks passed
@oleiade oleiade deleted the experimental/redis/update-version branch November 6, 2023 08:28
@olegbespalov olegbespalov added this to the v0.48.0 milestone Nov 8, 2023
oleiade added a commit that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants