Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin golang version to 1.21.5 in github actions and docker" #3492

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Dec 6, 2023

What?

This reverts commit 3808747.

Why?

We need that to release v0.48.0 with the latest golang version. But we really don't want to keep having to bump this every time so it is better to just use the wildcard version.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.49.0 milestone Dec 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47c0a26) 73.22% compared to head (57f81bd) 73.22%.

❗ Current head 57f81bd differs from pull request most recent head c8952eb. Consider uploading reports for the commit c8952eb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3492   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         267      267           
  Lines       20083    20083           
=======================================
+ Hits        14705    14706    +1     
+ Misses       4465     4463    -2     
- Partials      913      914    +1     
Flag Coverage Δ
ubuntu 73.17% <ø> (+<0.01%) ⬆️
windows 73.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codebien
Copy link
Contributor

codebien commented Dec 6, 2023

In my experience, it should be enough if we force the cache once then the next build should pick up the right version. We have workflow_dispatch for the build workflow so we might manually trigger a new job to force a build with a newly released Go version.

@codebien codebien requested review from a team and olegbespalov and removed request for joanlopez and a team December 6, 2023 13:32
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait a bit with merging. We have no pressure and could wait 1-2 days till actually the go 1.21.5 will be rolled out fully in CI.

@olegbespalov
Copy link
Contributor

@mstoykov since in any case we started "the great merging" see no more reasons for postponing this merge 👍

@mstoykov mstoykov merged commit e23ebec into master Dec 7, 2023
22 checks passed
@mstoykov mstoykov deleted the revertPinGoVersionForRelease branch December 7, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants