-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add browser tracing release notes #3522
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.49.0 #3522 +/- ##
==================================================
Coverage ? 73.18%
==================================================
Files ? 267
Lines ? 20076
Branches ? 0
==================================================
Hits ? 14692
Misses ? 4470
Partials ? 914
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
_what, why, and what this means for the user_ | ||
The browser module now generates traces that provide a representation of its inner workings, such as API methods executed (for example `browser.newPage` and `page.goto`), page navigations, and [Web Vitals](https://grafana.com/docs/k6/latest/using-k6-browser/metrics/#googles-core-web-vitals) measurements. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking on adding an image here of how a browser trace is visualized in Tempo, but I see it is not a common practice in release notes to add images. Should we add a folder under release notes/
for resources that are referenced in the release notes? Or is the text description good enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, a visual representation of this would be useful. Maybe best for the release email that goes out after the release instead of here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are your thoughts on this @mstoykov ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some minor things to ponder over, but happy as it is too.
|
||
_what, why, and what this means for the user_ | ||
The browser module now generates traces that provide a representation of its inner workings, such as API methods executed (for example `browser.newPage` and `page.goto`), page navigations, and [Web Vitals](https://grafana.com/docs/k6/latest/using-k6-browser/metrics/#googles-core-web-vitals) measurements. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, a visual representation of this would be useful. Maybe best for the release email that goes out after the release instead of here?
Co-authored-by: Ankur <ankur.agarwal@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
Merging this, we can review it once again with the full content from the |
What?
Adds release notes for tracing instrumentation implemented in k6 browser module.
Why?
Required step towards
v0.49.0
release.Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
grafana/xk6-browser#1100
grafana/xk6-browser#1104