Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k6-insights enabled check #3529

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

Blinkuu
Copy link
Contributor

@Blinkuu Blinkuu commented Jan 11, 2024

What?

Use raw Bool instead of ValueOrZero.

Why?

If the value hasn't been set by the user, the default value set to true in #3398 was not respected.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Fixes a bug introduced in #3398.

Use raw `Bool` instead of `ValueOrZero` to fetch a real underlying value, no matter if set by default or by user.
@Blinkuu Blinkuu added the cloud label Jan 11, 2024
@Blinkuu Blinkuu self-assigned this Jan 11, 2024
@Blinkuu Blinkuu requested a review from a team as a code owner January 11, 2024 10:37
@Blinkuu Blinkuu requested review from mstoykov and olegbespalov and removed request for a team January 11, 2024 10:37
@mstoykov mstoykov added this to the v0.49.0 milestone Jan 11, 2024
olegbespalov
olegbespalov previously approved these changes Jan 11, 2024
vortegatorres
vortegatorres previously approved these changes Jan 11, 2024
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blinkuu Please fix the tests. This likely is due to them now having tracing enabled by default. You can likely just disable it specifically for those tests.

@mstoykov mstoykov merged commit f423f54 into master Jan 12, 2024
21 checks passed
@mstoykov mstoykov deleted the fix-k6-insights-enabled-check branch January 12, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants