Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeql to v3 #3588

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Update codeql to v3 #3588

merged 1 commit into from
Feb 9, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Feb 9, 2024

What?

Switching to the most recent version of the CodeQL.

Why?

This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

An example: https://github.com/grafana/k6/actions/runs/7842697583

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov self-assigned this Feb 9, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner February 9, 2024 10:44
@olegbespalov olegbespalov requested review from oleiade and joanlopez and removed request for a team February 9, 2024 10:44
@olegbespalov olegbespalov changed the title codeql v1 is deprecated Update codeql to v3 Feb 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aabf8a1) 72.94% compared to head (6b2aadd) 72.90%.
Report is 1 commits behind head on master.

❗ Current head 6b2aadd differs from pull request most recent head 852c0d0. Consider uploading reports for the commit 852c0d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3588      +/-   ##
==========================================
- Coverage   72.94%   72.90%   -0.04%     
==========================================
  Files         280      278       -2     
  Lines       20952    20947       -5     
==========================================
- Hits        15283    15272      -11     
- Misses       4697     4700       +3     
- Partials      972      975       +3     
Flag Coverage Δ
macos 72.87% <ø> (?)
ubuntu 72.89% <ø> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov added the ci label Feb 9, 2024
@olegbespalov olegbespalov added this to the v0.50.0 milestone Feb 9, 2024
@olegbespalov olegbespalov merged commit 32c5f12 into master Feb 9, 2024
21 of 24 checks passed
@olegbespalov olegbespalov deleted the chore/update-codeql branch February 9, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants