Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop options.ext.loadimpact references #3602

Closed
wants to merge 2 commits into from

Conversation

andrewslotin
Copy link
Contributor

What?

A follow-up PR to use options.cloud instead of options.ext.loadimpact.

Why?

The legacy options.ext.loadimpact is superseded by options.cloud.

Checklist

  • I have performed a self-review of my code.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3348

@andrewslotin andrewslotin requested a review from a team as a code owner February 15, 2024 17:12
@andrewslotin andrewslotin requested review from oleiade and removed request for a team February 15, 2024 17:12
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5a6feb) 73.55% compared to head (85197d6) 73.51%.

❗ Current head 85197d6 differs from pull request most recent head 277d276. Consider uploading reports for the commit 277d276 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   73.55%   73.51%   -0.05%     
==========================================
  Files         277      275       -2     
  Lines       20228    20223       -5     
==========================================
- Hits        14879    14866      -13     
- Misses       4401     4405       +4     
- Partials      948      952       +4     
Flag Coverage Δ
macos 73.48% <100.00%> (+0.01%) ⬆️
ubuntu 73.51% <100.00%> (+0.03%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov
Copy link
Contributor

@andrewslotin, is there a need for this PR since we already have the changes as part of the #3407?

@andrewslotin
Copy link
Contributor Author

@olegbespalov, I've missed that one, but you might consider adding 277d276 there.

@olegbespalov
Copy link
Contributor

I've cherry-picked the 277d276 to the #3407 👍

@andrewslotin
Copy link
Contributor Author

Good, this PR then has no use 👍

@andrewslotin andrewslotin deleted the drop_ext_loadimpact_references branch February 19, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants