Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser#1097 release notes #3650

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Mar 18, 2024

What?

Updating the browser#1097 release notes to take into account the change to the API which is in browser#1244.

Why?

There's been a change in the API.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

grafana/xk6-browser#1244

The API has changed so that it requires working with the experimental
fs module to upload files from the local file system.
@ankur22 ankur22 changed the base branch from master to release-v0.50.0 March 18, 2024 12:18
@ankur22 ankur22 requested a review from inancgumus March 18, 2024 12:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-v0.50.0@70ac7ef). Click here to learn what that means.

❗ Current head d7b653e differs from pull request most recent head 131c3c6. Consider uploading reports for the commit 131c3c6 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             release-v0.50.0    #3650   +/-   ##
==================================================
  Coverage                   ?   73.56%           
==================================================
  Files                      ?      277           
  Lines                      ?    20244           
  Branches                   ?        0           
==================================================
  Hits                       ?    14893           
  Misses                     ?     4403           
  Partials                   ?      948           
Flag Coverage Δ
ubuntu 73.48% <ø> (?)
windows 73.42% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ankur22 ankur22 mentioned this pull request Mar 18, 2024
@ankur22 ankur22 merged commit 59b4c59 into release-v0.50.0 Mar 18, 2024
23 of 24 checks passed
@ankur22 ankur22 deleted the update/browser-1097-release-notes branch March 18, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants