-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lock module resolution after initialization #3680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic LGTM, just a request for improving the comment.
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3680 +/- ##
=======================================
Coverage 73.33% 73.33%
=======================================
Files 278 278
Lines 20329 20338 +9
=======================================
+ Hits 14908 14915 +7
- Misses 4477 4479 +2
Partials 944 944
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What?
Make it an error to try to resolve not previously resolved modules, after initialization
Why?
Partly because it should be given how we make k6 work and want
k6 archive
andk6 cloud
to "just work".Partly because this ended up being the only not completely hackish way to know that we are past the initialization state which was needed in order to make a warning only in the init context.
See #3681
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)