Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6/execution:Don't panic on accessing test.options #3708

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Apr 24, 2024

What?

Fixes a panic when accessing k6/execution.test.options in the init context.

Why?

Not to panic but give an exception.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@mstoykov mstoykov added this to the v0.51.0 milestone Apr 24, 2024
@mstoykov mstoykov requested a review from a team as a code owner April 24, 2024 08:22
@mstoykov mstoykov requested review from oleiade and olegbespalov and removed request for a team April 24, 2024 08:22
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.30%. Comparing base (b866c10) to head (9c2d7cf).

❗ Current head 9c2d7cf differs from pull request most recent head d357f49. Consider uploading reports for the commit d357f49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3708      +/-   ##
==========================================
+ Coverage   73.28%   73.30%   +0.02%     
==========================================
  Files         278      278              
  Lines       20389    20392       +3     
==========================================
+ Hits        14942    14949       +7     
+ Misses       4497     4493       -4     
  Partials      950      950              
Flag Coverage Δ
ubuntu 73.23% <100.00%> (+0.01%) ⬆️
windows 73.16% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

olegbespalov
olegbespalov previously approved these changes Apr 24, 2024
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we could use common.NewInitContextError helper.

js/modules/k6/execution/execution.go Outdated Show resolved Hide resolved
@mstoykov mstoykov merged commit 10e9a81 into master Apr 25, 2024
22 checks passed
@mstoykov mstoykov deleted the k6ExecutionPanics branch April 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants