Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling undefined function in timers #3776

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 6, 2024

What?

This PR fixes a panic that could be caused by a script like:

export default function() {
	setInterval(undefined, 100);
}

Why?

We shouldn't panic

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov added this to the v0.52.0 milestone Jun 6, 2024
@olegbespalov olegbespalov self-assigned this Jun 6, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner June 6, 2024 10:37
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team June 6, 2024 10:37
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.88%. Comparing base (bd114fd) to head (ec26402).

Current head ec26402 differs from pull request most recent head 5819f62

Please upload reports for the commit 5819f62 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3776      +/-   ##
==========================================
+ Coverage   70.87%   70.88%   +0.01%     
==========================================
  Files         291      291              
  Lines       21227    21229       +2     
==========================================
+ Hits        15044    15049       +5     
+ Misses       5218     5215       -3     
  Partials      965      965              
Flag Coverage Δ
ubuntu 70.81% <100.00%> (+<0.01%) ⬆️
windows 70.74% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov merged commit e5b00db into master Jun 7, 2024
23 checks passed
@olegbespalov olegbespalov deleted the fix/timers-panic branch June 7, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants