Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate to k6/browser from an experimental module #3793

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jun 11, 2024

What?

Provides two JS import paths:

  • k6/experimental/browser: The k6 browser sync API shipped in k6 0.51 (which we're planning to remove in k6 0.54).
  • k6/browser: The k6 browser async API.

Closes: #3778

Why?

  • Large breaking changes are no longer expected.
  • Async API w/Playwright compatibility and API stability.
  • Major runtime stability issues are fixed (although there are still some minor issues).
  • Tested on the cloud, and no regressions.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@inancgumus inancgumus self-assigned this Jun 11, 2024
@inancgumus inancgumus changed the title Graduate k6/browser from an experimental module Graduate to k6/browser from an experimental module Jun 11, 2024
@inancgumus inancgumus marked this pull request as ready for review June 11, 2024 10:07
@inancgumus inancgumus requested a review from a team as a code owner June 11, 2024 10:07
@inancgumus inancgumus requested review from mstoykov and removed request for a team June 11, 2024 10:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.87%. Comparing base (44d7840) to head (814e655).

Current head 814e655 differs from pull request most recent head e4feddc

Please upload reports for the commit e4feddc to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3793      +/-   ##
==========================================
+ Coverage   71.86%   71.87%   +0.01%     
==========================================
  Files         291      291              
  Lines       21249    21254       +5     
==========================================
+ Hits        15270    15277       +7     
+ Misses       4917     4915       -2     
  Partials     1062     1062              
Flag Coverage Δ
ubuntu 71.80% <100.00%> (+<0.01%) ⬆️
windows 71.73% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ankur22
ankur22 previously approved these changes Jun 11, 2024
Copy link
Contributor

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

cmd/tests/cmd_run_test.go Show resolved Hide resolved
js/jsmodules.go Outdated Show resolved Hide resolved
js/jsmodules.go Show resolved Hide resolved
@joanlopez joanlopez added this to the v0.52.0 milestone Jun 11, 2024
ankur22
ankur22 previously approved these changes Jun 11, 2024
joanlopez
joanlopez previously approved these changes Jun 12, 2024
js/jsmodules.go Outdated Show resolved Hide resolved
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
@inancgumus inancgumus dismissed stale reviews from joanlopez and ankur22 via e4feddc June 12, 2024 11:25
@inancgumus inancgumus merged commit 3415ce6 into master Jun 12, 2024
23 checks passed
@inancgumus inancgumus deleted the k6-browser-non-experimental branch June 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser: Register sync and async JS APIs (k6-core side)
7 participants