Tc39 + js/compiler changes #3831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
codebien and
joanlopez
and removed request for
a team
codebien
previously approved these changes
Jul 4, 2024
codebien
approved these changes
Jul 5, 2024
The changes revolve around moving away from compiling to mostly parsing the provided code. This will be relevant in ESM branch when only the parsing needs to be done for native ESM modules. For now it mostly adds some noise, but will make that PR a lot better. The changes to tc39 are mostly to make it nicer as well. The tc39 changes are quite strange as they definitely have *never* worked and do not work in k6 currently, so I have no idea what is happening there. It is very likely some error shadowing has been exposed.
joanlopez
reviewed
Jul 5, 2024
| @@ -70,9 +70,11 @@ func TestCompile(t *testing.T) { | |||
| t.Parallel() | |||
| c := New(testutils.NewLogger(t)) | |||
| src := `1+(function() { return 2; })()` | |||
| pgm, code, err := c.Compile(src, "script.js", true) | |||
There was a problem hiding this comment.
Nit; As the method is name Parse now, should we rename the test name to TestParse? 🤔
joanlopez
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Backporting changes from #3456 to make it smaller
Why?
Making that PR smaller makes it easier to review and potentially revert if needed.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)