Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k6/experimental/timers warning and consolidate with browsers #3837

Merged
merged 2 commits into from
Jul 11, 2024
Merged

Update k6/experimental/timers warning and consolidate with browsers #3837

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33ac431
Update k6/experimental/timers warning and consolidate with browsers
mstoykov Jul 11, 2024
ce4f44d
Apply suggestions from code review
mstoykov Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions js/jsmodules.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,13 @@ func getInternalJSModules() map[string]interface{} {
"k6/experimental/webcrypto": webcrypto.New(),
"k6/experimental/websockets": &expws.RootModule{},
"k6/experimental/timers": newWarnExperimentalModule(timers.New(),
"k6/experimental/timers is now part of the k6 core, please change your imports to use k6/timers instead."+
" The k6/experimental/timers will be removed in k6 v0.52.0"),
"Please update your imports to use k6/timers instead of k6/experimental/timers,"+
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we promote globally available timers instead?

" which will be removed after September 23rd, 2024(v0.54.0). Ensure your scripts are migrated by then."+
mstoykov marked this conversation as resolved.
Show resolved Hide resolved
" There are no API changes, so this is a drop in replacement."),
"k6/experimental/tracing": tracing.New(),
"k6/experimental/browser": newWarnExperimentalModule(browser.NewSync(),
"Please update your imports to use k6/browser instead of k6/experimental/browser,"+
" which will be removed after September 23rd, 2024. Ensure your scripts are migrated by then."+
" which will be removed after September 23rd, 2024(v0.54.0). Ensure your scripts are migrated by then."+
mstoykov marked this conversation as resolved.
Show resolved Hide resolved
" For more information, see the migration guide at the link:"+
" https://grafana.com/docs/k6/latest/using-k6-browser/migrating-to-k6-v0-52/"),
"k6/browser": browser.New(),
Expand Down