Cleanup comments and some code after ESM merge #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
previously approved these changes
Jul 19, 2024
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
olegbespalov
previously approved these changes
Jul 19, 2024
codebien
requested changes
Jul 19, 2024
| extended: base + Babel with parts of ES2015 preset | ||
| slower to compile in case the script uses syntax unsupported by base | ||
| base: pure Sobek - Golang JS VM supporting ES6+ | ||
| extended: base + sets "global" as alias for "globalThis" |
There was a problem hiding this comment.
Out of curiosity, what do we plan here? Do we drop in the future?
There was a problem hiding this comment.
good question - no answer at this point.
see #3860 for example
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
olegbespalov
approved these changes
Jul 19, 2024
codebien
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cleanup comments and messages around ESM merge
Why?
A lot of those comments no longer make sense with Babel gone and some refactoring of the internals
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)