Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust logging of the executor lack of work #3868

Merged

Conversation

athishaves
Copy link
Contributor

@athishaves athishaves commented Jul 21, 2024

What?

Changes log message level from Warn to Debug

Why?

In the case of cloud execution, it could confuse the customers since it could not be apparent to them if they should do something to improve or change, mainly because it has a warning level.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.
image

Related PR(s)/Issue(s)

Closes #3853

@athishaves athishaves requested a review from a team as a code owner July 21, 2024 19:54
@athishaves athishaves requested review from codebien and olegbespalov and removed request for a team July 21, 2024 19:54
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it! 👍

@olegbespalov olegbespalov added this to the v0.53.0 milestone Jul 22, 2024
@olegbespalov olegbespalov merged commit 00dafad into grafana:master Jul 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust logging of the executor lack of work
4 participants