Add discardResponseMessage option for gRPC stream
#3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzakharov
force-pushed
the
grpc-clien-stream-discard-response-message
branch
from
64c38bd
to
63d6682
Compare
lzakharov
requested review from
mstoykov and
olegbespalov
and removed request for
a team
olegbespalov
added
documentation-needed
olegbespalov
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
@lzakharov looks good to me! Thanks for the contribution! 🙇
We also have to update the k6-docs to reflect the actual state of the options, but k6-core team could take care of it
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new gRPC stream option
discardResponseMessage. See #3820.Why?
Parsing heavy responses can result in high CPU and memory usage.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
#3820