validate setupTimeout option

[tsukasaI]

What?

Validate setuptimeout option

Why?

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#1174

Manual test

Make t.js.

import http from 'k6/http';

export function setup() {
  console.log("setup called")
}

export default function() {
  const response = http.get("http://test.loadimpact.com");
};

Run this command with setupTimeone is 0s, and obtain error.

$ K6_SETUP_TIMEOUT=0s go run . run t.js

          /\      |‾‾| /‾‾/   /‾‾/   
     /\  /  \     |  |/  /   /  /    
    /  \/    \    |     (   /   ‾‾\  
   /          \   |  |\  \ |  (‾)  | 
  / __________ \  |__| \__\ \_____/ .io

ERRO[0000] setupTimeout must be positive                
exit status 104

[mstoykov]

👋 @tsukasaI this PR is now empty. I guessed you tried to revert them before making the changes discussed in the issue, but those have not been pushed.

Just pointing this out in case you think that was done and are waiting on us to review this - there is currently no code to review.

[tsukasaI]

Oh, sorry.
Just converted Draft.

[mstoykov]

I really don't think changing Apply signature is warranted.

We do validation checks for most of the options, and they all happen in the respected places instead of in Apply - so please do not change the signature of Apply - that will also make the change a lot smaller

[tsukasaI]

@mstoykov
Thank you for comment.

I updated to move in Validate method.
Is it reasonable?

[olegbespalov]

@tsukasaI LGTM! Thank you for your contribution!