Update to golangci-lint 1.60.1 to support go 1.23 #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once again a new release of go makes golangci-lint use all available memory. This also fixes some new linter issues, mostly: - staticheck dropping a bunch of checks - min/max overriding. They are now build-in in 1.21+, but I didn't want to replace them and bump to 1.21 in this commit already, given the whole toolchain thing. - printf not being error checked or not being used with format + arguments.
mstoykov
requested review from
codebien and
olegbespalov
and removed request for
a team
olegbespalov
previously approved these changes
Aug 16, 2024
Co-authored-by: Oleg Bespalov <oleg.bespalov@grafana.com>
olegbespalov
approved these changes
Aug 16, 2024
codebien
approved these changes
Aug 16, 2024
| // This is copied from lib/util.go to avoid circular imports. | ||
| func Clampf(val, min, max float64) float64 { | ||
| // Clampf returns the given value, "clamped" to the range [floor, ceiling]. | ||
| func Clampf(val, floor, ceiling float64) float64 { |
There was a problem hiding this comment.
Just as an observation, it does sound like something we might unexport. We don't use it outside of the pb package.
There was a problem hiding this comment.
I expect we will do this in one big sweep one day ... soon ™️ ;)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update golangci-lint to 1.60.1
Why?
Once again a new release of go makes golangci-lint use all available memory.
This also fixes some new linter issues, mostly:
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)