Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloud command not listed in k6 command's help text #3901

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Fix cloud command not listed in k6 command's help text #3901

merged 2 commits into from
Aug 21, 2024

Commits on Aug 19, 2024

  1. Fix cloud command not listed in k6 command's help text 

    When implementing the new cloud command structure, we marked the
k6 cloud command as deprecated by setting the cobra.Cmd Deprecated
option.

By doing so, Cobra took over itself to hide the command all in all from
the help text's output, and users couldn't see the cloud command as
part of the "Available Commands".

This commit removes the Cobra.Cmd Deprecated option usage, and ports
the message to the Long version of the help text.

This commit also rephrases the message to be more accurate. Considering
the cloud command itself is not deprecated, but rather its existing
behavior, we have mentioned the original behavior consisting in taking
a test resource as input is deprecated, specifically.
    @oleiade
    oleiade committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ae0d2b1 View commit details
    Browse the repository at this point in the history

  2. Add a root command test asserting the expected commands are available 

    This commit adds a test asserting the root command help text lists the
expected commands as available.
    @oleiade
    oleiade committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    757190f View commit details
    Browse the repository at this point in the history