Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded google.golang.org/grpc v1.64.1 => v1.65.0 #3912

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Aug 23, 2024

What?

This updates google.golang.org/grpc, which is nothing significant for the k6, but keeping the change diff tinier is better.

Why?

keeping the change diff tinier is better

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Aug 23, 2024
@olegbespalov olegbespalov added this to the v0.54.0 milestone Aug 23, 2024
@olegbespalov olegbespalov self-assigned this Aug 23, 2024
@olegbespalov olegbespalov requested a review from a team as a code owner August 23, 2024 15:00
@olegbespalov olegbespalov requested review from mstoykov and joanlopez and removed request for a team August 23, 2024 15:00
mstoykov
mstoykov previously approved these changes Aug 24, 2024
@mstoykov
Copy link
Contributor

Maybe run go mod tidy? I guess some lines should be dropped given the CI failure.

@olegbespalov
Copy link
Contributor Author

Maybe run go mod tidy?

The local go mod tidy using go1.20 showed nothing. If I run this using the go 1.22.6, it produces the diff like 4806b2f. Maybe we should make a separate PR for bringing this toolchain which is now defaults behavior, WDYT?

go.mod Outdated Show resolved Hide resolved
@mstoykov
Copy link
Contributor

Maybe we should make a separate PR for bringing this toolchain which is now defaults behavior, WDYT

Yeah, that probably is a good idea as I would prefer to have it separate.

Strangely grpc doesn't really specify 1.22 , so I guess we can specifiy 1.21.11 in the toolchain ... but let's discuss this in the separate PR. As I said in hte comment - we likely will upgrade to 1.23 for v0.54.0 either way.

@olegbespalov olegbespalov merged commit 66a5a36 into master Aug 26, 2024
22 checks passed
@olegbespalov olegbespalov deleted the dependecies/grpc branch August 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants