Switch to the go1.21, introduce toolchain to go.mod #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
requested review from
mstoykov and
joanlopez
and removed request for
a team
mstoykov
previously approved these changes
Aug 26, 2024
mstoykov
reviewed
Aug 26, 2024
olegbespalov
force-pushed
the
chore/toolchain
branch
from
1fd13a6
to
7970657
Compare
joanlopez
approved these changes
Aug 26, 2024
mstoykov
approved these changes
Aug 26, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR switches requirements go minimum 1.21 and introduces the
toolchaininto thego.modWhy?
Soon, we'll start actively use go 1.23, which leads us anyway to implement this change since
toolchainnowadays a default output of thego modChecklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)