js: DRY creation of a runner from archive in the tests #3935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was copy-pasted around and similar to how getSimpleRunner makes it hard to refactor if you add new fields that need to be around always.
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
olegbespalov
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor js tests so we do not repeat the same pattern to create a runner from an archive.
Why?
This was copy-pasted around and similar to how getSimpleRunner makes it hard to refactor if you add new fields that need to be around always.
We could also make a helper to create a runner + archive and run the provided test as function argument. But that would work in a lot less of the cases and isn't as necessary for #3917 to be a bit less noisy.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)