Raise TestStreamLogsToLogger log sending delay #3943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR raises the time given to the log emitter to wait for a "flush on the network" in the
cloudapi.TestStreamLogsToLogger
test. Instead of 5 milliseconds, we now wait 25 milliseconds.Why?
During the development of #3931, we discovered that the
cloud API.TestStreamLogsToLogger
test was very flaky on Windows. We weren't able to reproduce locally, but through experimentation, we were able to isolate and confirm thattime.Sleep(5 * time.Millisecond)
was likely the culprit.Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
#3931