Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise TestStreamLogsToLogger log sending delay #3943

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

oleiade
Copy link
Member

@oleiade oleiade commented Sep 11, 2024

What?

This PR raises the time given to the log emitter to wait for a "flush on the network" in the cloudapi.TestStreamLogsToLogger test. Instead of 5 milliseconds, we now wait 25 milliseconds.

Why?

During the development of #3931, we discovered that the cloud API.TestStreamLogsToLogger test was very flaky on Windows. We weren't able to reproduce locally, but through experimentation, we were able to isolate and confirm that time.Sleep(5 * time.Millisecond) was likely the culprit.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3931

@oleiade oleiade marked this pull request as ready for review September 11, 2024 08:43
@oleiade oleiade requested a review from a team as a code owner September 11, 2024 08:43
@oleiade oleiade requested review from mstoykov and joanlopez and removed request for a team September 11, 2024 08:43
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 11, 2024
@oleiade oleiade merged commit 4dc9d97 into master Sep 11, 2024
22 checks passed
@oleiade oleiade deleted the fix_cloudapi_teststreamlogstologger_flakiness branch September 11, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants