Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to k6 browser 1.8.3 #3965

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update to k6 browser 1.8.3 #3965

merged 1 commit into from
Sep 23, 2024

Conversation

ankur22
Copy link
Contributor

@ankur22 ankur22 commented Sep 23, 2024

What?

Fixes a NPD in elementHandle.checkHitTargerAt in the browser module.

Why?

Avoids aborts which may not be needed.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Fixes a NPD in `elementHandle.checkHitTargerAt` in the browser module.
@ankur22 ankur22 requested a review from a team as a code owner September 23, 2024 12:16
@ankur22 ankur22 requested review from mstoykov and olegbespalov and removed request for a team September 23, 2024 12:16
@olegbespalov olegbespalov added this to the v0.54.0 milestone Sep 23, 2024
@olegbespalov olegbespalov added the dependencies Pull requests that update a dependency file label Sep 23, 2024
@ankur22 ankur22 merged commit 2c0db5d into master Sep 23, 2024
22 checks passed
@ankur22 ankur22 deleted the update/browser-1.8.3 branch September 23, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants