Better error message when using the open function outside init code #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 62.89% 62.91% +0.02%
==========================================
Files 96 96
Lines 7217 7221 +4
==========================================
+ Hits 4539 4543 +4
Misses 2429 2429
Partials 249 249
Continue to review full report at Codecov.
|
robingustafsson
requested changes
Mar 28, 2018
js/runner.go
Outdated
| @@ -172,6 +172,11 @@ func (r *Runner) newVU() (*VU, error) { | |||
| BPool: bpool.NewBufferPool(100), | |||
| } | |||
| vu.Runtime.Set("console", common.Bind(vu.Runtime, vu.Console, vu.Context)) | |||
| common.BindToGlobal(vu.Runtime, map[string]interface{}{ | |||
| "open": func() { | |||
| common.Throw(vu.Runtime, errors.New("open function it is only available at init code")) | |||
There was a problem hiding this comment.
I'd rephrase the error message as:
"open" function is only available to the init code (aka global scope), see https://docs.k6.io/docs/test-life-cycle for more information
I think including a link to the docs is helpful, but it of course adds some burden on us to make sure those links keep working if we change the URL
na--
approved these changes
Mar 29, 2018
na--
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #543