Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect setup and teardown timeouts even when tirggered by the API #661

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Jun 1, 2018

No description provided.

@na-- na-- force-pushed the setup-teardown-timeout-fixes branch from f1ba179 to 5b1dabd Compare June 1, 2018 09:50
@codecov-io
Copy link

codecov-io commented Jun 1, 2018

Codecov Report

Merging #661 into master will decrease coverage by 0.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage    64.5%   64.48%   -0.02%     
==========================================
  Files         101      101              
  Lines        8127     8130       +3     
==========================================
+ Hits         5242     5243       +1     
- Misses       2547     2548       +1     
- Partials      338      339       +1
Impacted Files Coverage Δ
js/runner.go 80.3% <100%> (+1.04%) ⬆️
core/local/local.go 78% <66.66%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216bd1e...d4fd738. Read the comment docs.

@na-- na-- merged commit 279c384 into master Jun 1, 2018
@na-- na-- deleted the setup-teardown-timeout-fixes branch June 1, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants