Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug with --no-color and wrap Go's std logger with logrus #712

Merged
merged 2 commits into from
Jul 16, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Jul 16, 2018

As noted in #711, for some reason Go's standard library sometimes logs errors and warnings instead of returning them... But since we exclusively use github.com/sirupsen/logrus for logging in k6, those messages looked very different and didn't obey the --logformat configuration...

While fixing this, I noticed the (probably copy-paste) error stdout.Writer = colorable.NewNonColorable(os.Stderr) and fixed that as well 😅

@codecov-io
Copy link

codecov-io commented Jul 16, 2018

Codecov Report

Merging #712 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   64.38%   64.37%   -0.01%     
==========================================
  Files         101      101              
  Lines        8275     8276       +1     
==========================================
  Hits         5328     5328              
- Misses       2598     2599       +1     
  Partials      349      349
Impacted Files Coverage Δ
cmd/root.go 26.66% <0%> (-0.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b2516...e56f969. Read the comment docs.

@na-- na-- merged commit 7796615 into master Jul 16, 2018
@na-- na-- deleted the logger-fixes branch July 16, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants