Fix a bug with --no-color and wrap Go's std logger with logrus #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #711, for some reason Go's standard library sometimes logs errors and warnings instead of returning them... But since we exclusively use
github.com/sirupsen/logrus
for logging in k6, those messages looked very different and didn't obey the--logformat
configuration...While fixing this, I noticed the (probably copy-paste) error
stdout.Writer = colorable.NewNonColorable(os.Stderr)
and fixed that as well 😅