Feature/504 http discard response #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 64.14% 64.17% +0.03%
==========================================
Files 101 101
Lines 8381 8394 +13
==========================================
+ Hits 5376 5387 +11
- Misses 2650 2651 +1
- Partials 355 356 +1
Continue to review full report at Codecov.
|
na--
reviewed
Aug 14, 2018
js/modules/k6/http/http_request.go
Outdated
| @@ -329,6 +331,8 @@ func (h *HTTP) parseRequest(ctx context.Context, method string, reqURL URL, body | |||
| result.timeout = time.Duration(params.Get(k).ToFloat() * float64(time.Millisecond)) | |||
| case "throw": | |||
| result.throw = params.Get(k).ToBoolean() | |||
| case "discardresponsebody": | |||
There was a problem hiding this comment.
Can you change this in camelCase as well, i.e. discardResponseBody?
| @@ -367,6 +367,12 @@ func TestOptions(t *testing.T) { | |||
| opts := Options{}.Apply(Options{RunTags: tags}) | |||
| assert.Equal(t, tags, opts.RunTags) | |||
| }) | |||
| t.Run("DiscardResponseBody", func(t *testing.T) { | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
na--
added a commit
that referenced
this pull request
Aug 17, 2018
Add #742 to the release notes and improve the noCookiesReset blurb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discard Response Body Feature implementation
You can use it either globaly (k6 run --discard-response-body xxx.js)
... or per-request within a script:
_let params = { discardresponsebody: true }
r= http.get("http://your.test.com/url", params);